Register ProjectQuota multicluster router in main#831
Merged
Conversation
PR #827 added ProjectQuotaResourceRouter but never registered it in the ResourceRouters map in cmd/manager/main.go. Without this registration, ProjectQuota CRDs are not routed to the correct per-AZ clusters in multi-cluster deployments. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
cortex-ai-agents
Bot
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
umswmayj
approved these changes
May 11, 2026
Contributor
Test Coverage ReportTest Coverage 📊: 69.1% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #827 split the ProjectQuota CRD into per-AZ CRDs and added a ProjectQuotaResourceRouter in pkg/multicluster/routers.go, but this router was never registered in the ResourceRouters map in cmd/manager/main.go. This is the same class of bug that affected FlavorGroupCapacity (fixed in PR #828) where the router implementation existed but was not wired into the manager entrypoint.
Without this registration, ProjectQuota CRDs are not routed to the correct per-AZ clusters in multi-cluster deployments, meaning quota data would not be synced properly. This commit adds the ProjectQuota GVK and its corresponding ProjectQuotaResourceRouter to the ResourceRouters map, following the exact same pattern used by all other registered routers.
🤖 Generated with Claude Code